Code review

20
Code Review Systems Sway Wang

Transcript of Code review

Page 1: Code review

Code Review SystemsSway Wang

Page 2: Code review
Page 3: Code review

Gerrit

Page 4: Code review
Page 5: Code review
Page 6: Code review
Page 7: Code review

Verify

Page 8: Code review

GitHub Pull Request

Page 9: Code review
Page 10: Code review
Page 11: Code review

Pull Request

Page 12: Code review

Merge Pull Request

Page 13: Code review

Phabricator - Differential

• FACEBOOK內部使用的系統• PHP• 支援 pre-commit, post-commit

Page 14: Code review

Workflow• An author prepares a change to a codebase, then sends it for review.

They specify who they want to review it (additional users may be notified as well, see below). The change itself is called a "Differential Revision".

• The reviewers receive an email asking them to review the change.• The reviewers inspect the change and either discuss it, approve it, or

request changes (e.g., if they identify problems or bugs).• In response to feedback, the author may update the change (e.g.,

fixing the bugs or addressing the problems).• Once everything is satisfied, some reviewer accepts the change and

the author pushes it to the upstream.

Page 15: Code review
Page 16: Code review
Page 17: Code review

Review Board Workflow

Page 18: Code review
Page 19: Code review
Page 20: Code review