Code review
Transcript of Code review
Code Review SystemsSway Wang
Gerrit
Verify
GitHub Pull Request
Pull Request
Merge Pull Request
Phabricator - Differential
• FACEBOOK內部使用的系統• PHP• 支援 pre-commit, post-commit
Workflow• An author prepares a change to a codebase, then sends it for review.
They specify who they want to review it (additional users may be notified as well, see below). The change itself is called a "Differential Revision".
• The reviewers receive an email asking them to review the change.• The reviewers inspect the change and either discuss it, approve it, or
request changes (e.g., if they identify problems or bugs).• In response to feedback, the author may update the change (e.g.,
fixing the bugs or addressing the problems).• Once everything is satisfied, some reviewer accepts the change and
the author pushes it to the upstream.
Review Board Workflow